justadudewhohacks / justadudewhohacks/opencv4nodejs

houghLinesP test should include comments of x1, x2, y1, y2

Open
#252 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5.1k
Forks
826
PR merge metrics
No merged PRs in 30d

Description

This is the correct mapping from a Vec4 to x1, x2, y1, y2.
```
const y2 = line.x;
const y1 = line.z;
const x1 = line.y;
const x2 = line.w;
```
Perhaps this can be added to the test-case to document the return value better.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.