juspay / juspay/superposition

Unsafe read for update

Open
#588 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug tech-debt
Dominant language
Rust
Stars
429
Forks
49
Avg merge
2d 3h
Merged PRs (30d)
10

Description

Issue

in most places we are reading data which is meant for update either outside transaction or inside transaction, but the read data is not locked for further reads which can lead to missed updates as the data being committed later on would have done so based on old data

Solution

Read data meant for dictating updates inside transaction with FOR UPDATE constraint (via diesel's .for_update() to lock the data

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating reads that determine updates and reviewing their surrounding transaction boundaries. Check how Diesel's .for_update() can be applied to those reads, then verify that concurrent updates no longer use stale data; the issue names no files or tests, so the affected scope must be established first.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.