juspay / juspay/hyperswitch

fix: resolve all the fields in payment_method related functions

Open
#256 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
43.7k
Forks
5.1k
Avg merge
2d 20h
Merged PRs (30d)
205

Description

## Description
After the current changes in the card locker, there are a few fields that were (left empty/contain dummy values) as they were pending on further discussions. These fields need to be addressed going forward

## Changes
Following are the functions that are in need of a fix
- [ ] `router::core::payment_methods::transformers::mk_add_card_response`
- [ ] `router::core::payment_methods::transformers::mk_add_card_request`
- [ ] `router::core::payment_methods::transformers::get_card_detail`

Contributor guide

Open the contributing guide

Research direction

Start with router::core::payment_methods::transformers::mk_add_card_response, mk_add_card_request, and get_card_detail. Review the current card-locker changes and any related discussions to determine the expected values for each field, then verify that these functions no longer return empty or dummy fields using the relevant payment-method tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
payments
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.