juspay / juspay/hyperswitch

Fold `sampler.enabled` into `mode = "record"` (deja recording config)

Open
#13,435 0 comments 0 reactions 0 assignees View on GitHub
C-tracking-issue
Dominant language
Rust
Stars
43.7k
Forks
5.1k
Avg merge
2d 21h
Merged PRs (30d)
210

Description

Record mode is meaningless without the per-request sampler: a record-mode process with the sampler disabled should not be representable.

Collapse the two knobs so that `mode = "record"` implies the sampler, and drop (or derive) the separate `[deja.sampler] enabled` flag from the settings surface introduced by the recording-sink/boot PR. This is a pure config-surface simplification with no behavior change for a correctly-configured deployment — it just removes a footgun state (`mode = "record"` + `sampler.enabled = false`) that can only misconfigure a recording fleet.

Contributor guide

Open the contributing guide

Research direction

Start with the recording-sink/boot settings surface mentioned in the issue and trace how mode and sampler.enabled are represented. Check the existing configuration behavior for record mode, then remove or derive the separate enabled flag while preserving correctly configured deployments. Done means the invalid record-plus-disabled-sampler state is no longer representable.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.