jupyterlab / jupyterlab/pull-requests

nbdime diff algorithm... not quite like Myers algorithm

Open
#22 0 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
38
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Git diff is using Myers algorithm by default on raw text lines. Its output can be quite different compare to nbdime diff for notebooks. And therefore when creating new comment, it is not uncommon that upon reload the comment position changes.

> This is especially true with GitLab that requires the line in the original and the new file to comment on an unmodified line.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.