jupyterlab / jupyterlab/extension-examples

Align CSS classnames definition

Open
#149 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
516
Forks
187
PR merge metrics
No merged PRs in 30d

Description

...the documentation seemed to indicated that they were moving away from that practice: "CSS classnames are defined inline in the code. We used to put them as all caps file-level consts, but we are moving away from that." (https://jupyterlab.readthedocs.io/en/stable/developer/css.html)

_Originally posted by @adpatter in https://github.com/jupyterlab/extension-examples/pull/148#r575694491_

It would be good to align the example with the JupyterLab recommendation

Contributor guide

No contributing guide indexed for this repository

Research direction

Read the JupyterLab CSS documentation linked in the issue, then locate the example whose CSS class names are defined as file-level constants. Align that example with the documented recommendation and verify that its class names still work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.