jupyterhub / jupyterhub/nbgitpuller

Add url parameter to prevent redirection after syncing

Open
#83 11 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
237
Forks
86
PR merge metrics
No merged PRs in 30d

Description

hey

I'm playing with the idea of adding a *notebook* extension that would leverage the current serverextension

so as a very naive / preliminary idea I took a plain notebook and manually added links that exercise the `/git-pull` handle

my toy notebook is here
https://github.com/parmentelat/nbh-nbgitpuller/blob/master/python3.ipynb
and the raw version is
https://raw.githubusercontent.com/parmentelat/nbh-nbgitpuller/master/python3.ipynb

what i can see is that

* when I use the broken link, i.e. one that has an invalid `repo=` setting, clicking opens a new tab where i can see a terminal dump with the git error
* when I use a proper link however, things also go in a separate tab, where i fugitively see a progressbar, but then that tab gets redirected to the classic view for my directory;

I take it that if I had mentioned a specific notebook I would have been redirected there, and I get the idea; however in my use case, because I'd like users to be able to check by themselves the details of what happened, I'd like the second case to stop short and to **not** redirect anywhere; ending up in a terminal session like the first case would be just fine

would that be an acceptable addition to the url API ? like adding redirect=false or similar

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.