jupyterhub / jupyterhub/nbgitpuller

nbgitpuller link generator: Repo name doesn't get properly populated for Binder links using a Custom URL for "Application to Open"

Open
#230 1 comment 1 reaction 0 assignees View on GitHub
bug
Dominant language
Python
Stars
237
Forks
86
PR merge metrics
No merged PRs in 30d

Description

### Bug description

Hello! I've been playing around with the nbgitpuller link generator for one of my projects and I noticed that when I try to use a Custom URL to open my notebook in (in this case, a rendered Voila dashboard), the repo name doesn't get properly populated in the link, instead showing "undefined". I think this bug is restricted to just the Binder panel.

#### Expected behaviour

I expect the repo name to be properly populated in the nbgitpuller link, like in this example when I choose the Classic Notebook interface.

![expected_behaviour](https://user-images.githubusercontent.com/44771837/141496912-92af5764-7888-4acb-931a-1b378b5f6b2b.jpg)

#### Actual behaviour

"undefined" is being populated as the name of the repo in the nbgitpuller link when generated using a Custom URL for Binder links

![incorrect_nbgitpuller_link](https://user-images.githubusercontent.com/44771837/141496795-ffcfb507-24af-4be1-89bc-a966b978a724.jpg)

### How to reproduce

1. Go to https://jupyterhub.github.io/nbgitpuller/link.html
2. Click on the Binder panel
3. Fill in the form with some dummy values
4. Select "Custom URL" for "Application to Open" and fill in a dummy value
5. See error in the generated link

### Your personal set up

- Browser: Google Chrome
- Version(s): 95.0.4638.69 (Official Build) (x86_64)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.