CTRL+F/CMD+F overrides browser's Find function with custom code
- Dominant language
- Jupyter Notebook
- Stars
- 13.3k
- Forks
- 5.8k
- Avg merge
- 6d 11h
- Merged PRs (30d)
- 7
Description
## Description
When the user presses CTRL+F or CMD+F, custom JupyterLab code for Find appears. This behavior differs from the classic notebook (https://github.com/jupyter/nbclassic/) which does not override these shortcut keys, and which instead allows the browser's built-in search bar to be displayed and used.
## Expected behavior
By default, in Notebook 7, CTRL+F or CMD+F should cause the browser's default search user interface to display.
## Context
This was spun off from #7041, originally filed by @jph00.
Jupyter Notebook should not override browsers' built-in keyboard shortcuts, wherever possible.
Virtual rendering may cause the browser's search box to search only a portion of the notebook; unrendered cells may not be made available to the browser.
Contributor guide
Research direction
Compare Notebook 7's CTRL+F/CMD+F behavior with the classic notebook linked in the issue, then trace where the browser shortcut is overridden. Check how virtual rendering affects browser search, and verify that the browser's built-in search UI is used by default without breaking notebook search behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100