jupyter / jupyter/notebook

Find/replace highlighting keeps coming back up after find prompt closed

Open
#6,975 3 comments 2 reactions 0 assignees View on GitHub
bug
Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

## Description

Highlighting for find/replace in text editor comes back unexpectedly after closing find interface and typing additional text.
![Screenshot 2023-07-21 130935](https://github.com/jupyter/notebook/assets/1227014/3d46c8ef-b616-47c8-994b-888984895572)
![Screenshot 2023-07-21 131004](https://github.com/jupyter/notebook/assets/1227014/4f2e96d3-313f-4bab-ab5b-71202dd4dc15)

## Reproduce

1. Open a text document in jupyter notebook.
2. Ctrl-f or use Edit -> Find... to open the find prompt.
3. Type string you want to find
4. Press enter to highlight matching cases in your document
5. Press esc to close the find interface
6. Type any new character - the find highlighting will reappear despite the closed interface.

This seems to only affect the text editor, not find/replace behavior within jupyter notebook cells.

Highlighting is resolved by clearing the find query before closing the find/replace interface.

## Expected behavior

Text should remain unhighlighted until the find/replace interface is re-opened.

## Context

- Operating System and version: Windows 10 Enterprise
- Browser and version: Chrome 114.0.5735.199

- Jupyter Notebook version: 7.0.0

Troubleshoot Output

[troubleshoot.txt](https://github.com/jupyter/notebook/files/12131167/troubleshoot.txt)

Command Line Output

[command_line.txt](https://github.com/jupyter/notebook/files/12131168/command_line.txt)

Browser Output

No output.

Contributor guide

Open the contributing guide

Research direction

Start in the Jupyter Notebook 7 text editor's find interface and reproduce the behavior using the listed steps. Confirm that closing the interface leaves the document unhighlighted while typing, and verify that find highlighting still works when the interface is reopened.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.