jupyter / jupyter/notebook

Investigate `headed` differences in the UI tests for Firefox

Open
#6,876 0 comments 0 reactions 0 assignees View on GitHub
maintenance
Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

In https://github.com/jupyter/notebook/pull/6872 we noticed some differences for the rendering of the "Click to add a cell" button in Firefox when running the Playwright tests.

**default** (on CI)

The "Click to add a cell" button is displayed even when not actively hovering on it.

![image](https://github.com/jupyter/notebook/assets/591645/5263df11-6a82-4498-8730-372b1f28b746)

**--headed**

The "Click to add a cell" button is **not** displayed, which is the expected behavior.

![image](https://github.com/jupyter/notebook/assets/591645/205fb54a-a0df-4541-bd13-d8ea36e60efc)

We should consider investigating this more or report an issue on https://github.com/microsoft/playwright. Or check again later if the workaround can be removed in a future Playwright version:

https://github.com/jupyter/notebook/blob/c77ebdcfbf338a457b6119ac0be0cf344ab734bf/ui-tests/test/utils.ts#L38-L48

Contributor guide

Open the contributing guide

Research direction

Start with ui-tests/test/utils.ts lines 38-48 and reproduce the Firefox Playwright tests in default and --headed modes. Compare the rendering of the “Click to add a cell” button, then determine whether the workaround can be removed, should remain, or warrants a Playwright issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook, playwright
Domain
frontend, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.