'Delete' does not reflect 'FileContentsManager.delete_to_trash'
- Dominant language
- Jupyter Notebook
- Stars
- 13.3k
- Forks
- 5.8k
- Avg merge
- 6d 11h
- Merged PRs (30d)
- 7
Description
Notebooks will "delete" non-empty directories if `FileContentsManager.delete_to_trash` is set `True` - though it actually just copies them to `.local/share/Trash`.
However, the message in the confirmation still says "Are you sure you want to permanently delete" - the word "permanently" is misleading in this context.
The message should check the state of the `delete_to_trash` flag, and be worded appropriately

Contributor guide
Research direction
Locate the notebook delete confirmation UI and trace how it can access FileContentsManager.delete_to_trash. Check the wording for both flag states, then update it so the confirmation accurately distinguishes trashing from permanent deletion. Done means the message no longer says “permanently” when delete_to_trash is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter-notebook
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100