jupyter / jupyter/notebook

Erroneous edit shortcuts dialogue when closing keyboard shortcut dialogue.

Open
#4,906 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

Click Keyboard shortcuts, then in the top right, there's a button that says "edit shortcuts" if you click that button, it'll close the keyboard shortcut dialogue and then open up the edit command mode shortcuts dialogue. That's as expected.

After doing that, open up keyboard shortcuts again and close it. The edit shortcuts window will come up again, but it shouldn't have.

I'm using notebook server 6.0.0 with python 3.7
Happens on Firefox 69 and Chrome 76

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the sequence through the Keyboard shortcuts and Edit shortcuts dialogs in Firefox or Chrome: open Edit shortcuts, reopen Keyboard shortcuts, and close it. Trace the dialog state transition responsible for reopening Edit shortcuts, then verify that closing Keyboard shortcuts no longer reopens it.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.