jupyter / jupyter/notebook

Move tests to py.test

Open
#4,753 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

Currently most of notebook/tests (except the selenium ones) are all using the built-in unittest module. Native pytest format tests (with just functions) feels more readable and better adopted now. We also use it a lot in other parts of the ecosystem.

How do people feel about moving?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the tests under notebook/tests, separating the selenium tests as the issue requests, and identifying which files use Python's unittest module. Check the existing discussion before proposing a migration plan. Done would mean an agreed scope and all targeted non-selenium tests using native pytest function format while remaining runnable.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.