jupyter / jupyter/notebook

Do not autologin with webbrowser.open.

Open
#4,017 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

When running `jupyter notebook`, this will automatically login users, thus preventing them to see the login page allowing them to set a password.

screen shot 2018-09-21 at 11 11 35

I suggest to change the flow so that on startup it does not pass `?token=...` but `?prefill_token=...`, stop users on above page by pre-filling the token, and let users set-up a password.

Contributor guide

Open the contributing guide

Research direction

Start with the startup flow for `jupyter notebook`, particularly the path that calls `webbrowser.open` and adds the token query parameter. Trace how the login page handles that parameter; done means startup uses `prefill_token` instead of `token`, allowing users to reach the page and set a password.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook
Domain
authentication, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.