jupyter / jupyter/notebook

Bidi Support design proposal for (Numeric Shaping , National Calendar and UI Mirroring)

Open
#2,178 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
13.3k
Forks
5.8k
Avg merge
6d 11h
Merged PRs (30d)
7

Description

This is the proposed low level design of the three requested bidi features ( #2156 , #2154 and #1852 ).

- Creation of **bidi / js** folders under notebook/static to wrap the whole bidi work as the below screenshot.

![herierichy of bidi folder](https://cloud.githubusercontent.com/assets/20149645/22862818/841a87b2-f13e-11e6-8db9-cad4340eab8f.png)

- Under **bidi /js** there will be two files:

- **bidi.js:** the interface that hold the bidi function to be invoked.
- **numericshaping.js:** has the core functions of numeric shaping support.

![class diagram](https://cloud.githubusercontent.com/assets/20149645/22862852/57dd8612-f13f-11e6-9807-c632185f8024.png)

- **Following is bidi.js in more details:**
The bidi API contains the following functions with respect to each feature:

![bidi js functions for each feature](https://cloud.githubusercontent.com/assets/20149645/22863095/11685870-f143-11e6-90b5-66580b0274dc.png)

At the moment , I need any UI component to control the user preference if we enable the bidirectional behavior.

Thanks and Waiting your Comments .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.