jupyter / jupyter/nbformat

Should normalize update minor_version?

Open
#328 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
313
Forks
176
PR merge metrics
No merged PRs in 30d

Description

Currently if I run a v 4.0 notebook through `nbformat.validator.normalize`, it will add cell ids, but it will leave the minor version as 0. Shouldn't it be updated to 5 to highlight that it now includes some fields that was added in that version of the schema? Since the previous versions have the schema with `additionalProperties: false`, the new notebook will be invalid against the 4.0 schema.

Contributor guide

Open the contributing guide

Research direction

Start at the nbformat.validator.normalize entry point and trace how it handles notebook versions, cell IDs, and schema fields. Confirm whether normalization should update minor_version from 4.0 when it adds fields introduced by version 5, then verify the resulting notebook against the relevant schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.