junegunn / junegunn/fzf

Korean characters remain with scrolling.

Open
#2,194 0 comments 0 reactions 0 assignees View on GitHub
windows
Dominant language
Go
Stars
83k
Forks
2.9k
Avg merge
17h 8m
Merged PRs (30d)
10

Description

- [x] I have read through the manual page (`man fzf`)
- [x] I have the latest version of fzf
- [x] I have searched through the existing issues

## Info

- OS
- [ ] Linux
- [ ] Mac OS X
- [x] Windows
- [ ] Etc.
- Shell
- [ ] bash
- [ ] zsh
- [ ] fish
- [x] cmd.exe

## Problem / Steps to reproduce

Browsing directory with file names in Korean(non-Latin?) will leave some ghost chars in the console window as you scroll up/down.

At first, I found this issue in a VIM-embedded terminal. But when I tested in other environments (neovim, detached/embedded FZF windows, GUI/text), result was the same. Korean chars are left always. However I haven't tested it in native Linux terminal.

![image](https://user-images.githubusercontent.com/639708/94355658-e3c52100-00c0-11eb-9cf5-5ff8f623a352.png)

Also the issue can be easily reproduced with the attached text file.
```type text.txt | fzf.exe```

[test.txt](https://github.com/junegunn/fzf/files/5287713/test.txt)

![image](https://user-images.githubusercontent.com/639708/94355804-48cd4680-00c2-11eb-843d-17b75443505b.png)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the rendering problem on Windows with cmd.exe using `type text.txt | fzf.exe`, then scroll through the attached text file containing Korean filenames. Compare the console output while scrolling; done means Korean characters no longer remain as ghost characters in the terminal.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.