junegunn / junegunn/fzf.vim

`:History:` never honors "Press ENTER or type command to continue"

Open
#1,346 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Vim Script
Stars
10.3k
Forks
608
Avg merge
5d 8h
Merged PRs (30d)
2

Description

- [x] I have fzf 0.23.0 or above
- [x] I have read through https://github.com/junegunn/fzf.vim/blob/master/README.md
- [x] I have read through https://github.com/junegunn/fzf/blob/master/README-VIM.md
- [x] I have read through the manual page of fzf (`man fzf`)
- [x] I have searched through the existing issues

```
smckown@x230:~$ fzf --version
0.28.0 (e4c3ecc)
smckown@x230:~$ vim --version | head -2
VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Sep 28 2021 11:18:09)
Included patches: 1-3458
```

Minimal test config, `test.vim`:
```
call plug#begin('~/.vim/plugged')
Plug 'junegunn/fzf', { 'do': { -> fzf#install() } }
Plug 'junegunn/fzf.vim'
Plug 'tpope/vim-fugitive'
call plug#end()

set nocompatible
```

Normally output from `:Git commit ...` in vim is emitted as if it is an external command. That is, the command output shows up at the bottom of the screen as the terminal window scrolls, then Vim says `Press ENTER or type command to continue`.

If I retrieve a `:Git commit ...` from history using `q:`, the command output is also rendered as described above.

However, if I select a `:Git commit ...` from history via `:History:`, the git commit output is rendered instead in a new Vim buffer/window.

tpope said, on https://github.com/tpope/vim-fugitive/discussions/1875:
> :Git commit does use the "Press ENTER" variant by default. It should only use the window version if you've done something like set pager.commit in your Git config.

Is there a way to avoid the differing behavior when using `:History:`? I've left a link to this issue at https://github.com/tpope/vim-fugitive/discussions/1875.

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the behavior with the provided test.vim configuration, comparing :Git commit output with q: and :History:. Start by tracing the :History: command path in fzf.vim and compare it with normal command execution; done means selecting a history entry preserves the expected Vim "Press ENTER or type command to continue" behavior instead of opening a new buffer.

Written by the indexing model from the issue text.

Assessment

Tech stack
vim
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.