junegunn / junegunn/fzf.vim

:Commits command: allow users to change sink?

Open
#1,076 0 comments 1 reaction 0 assignees View on GitHub
invalid: missing template
Dominant language
Vim Script
Stars
10.3k
Forks
608
Avg merge
5d 8h
Merged PRs (30d)
2

Description

As far as I understand, now you can't redefine actions for `:Commits`/`:BCommits` without changing `fzf.vim/autoload/fzf/vim.vim`, am I correct?

If so -- and since `:Commits` relies on the external dependency, vim-fugitive, which may or may not be installed -- it would be great to allow users to set the sink actions via some configurable variable may be? And if no such variable is defined, then use the default predefined sink, `s:commits_sink()`.

What do you think?

Contributor guide

No contributing guide indexed for this repository

Research direction

Read fzf.vim/autoload/fzf/vim.vim and trace the :Commits and :BCommits definitions, including the default s:commits_sink() and their vim-fugitive dependency. Done means users can configure the sink actions without editing that file, while the existing sink remains the fallback when no variable is defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, vim
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.