juliangruber / juliangruber/tmp-stream

does not copy end/close listener in replace

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

because this stream is supposed to be the replaced stream and pipe does not bubble end/close events any stream "replaced" will fail to end the replaced stream if the consumer of said stream must end it.

this causes multilevel to leak live streams on the server that have been ended on the client. the server will continue sending data forever.

fixed in multilevel here https://github.com/juliangruber/multilevel/pull/57 but the fix may belong here

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.