juliangruber / juliangruber/multilevel-http

Bug: client doesn't return error for bad http codes

Open
#4 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
49
Forks
10
PR merge metrics
No merged PRs in 30d

Description

Example: if the server responds with `Internal Error 500`, the params returned by the `request` module are `(null, res, body)` [and res.statusCode === 500].

We need a 'middleware' kind of function that checks for the `statusCode`, otherwise the client may be tricked into believing `db.del` || `db.put` (and others) succeeded.

I'll work on this.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.