jthegedus / jthegedus/docsify-select

Menu-label values should allow spaces before a list item

Open
#5 0 comments 0 reactions 1 assignee View on GitHub

@jthegedus is already working on this.

Since Apr 17, 2020.

bug
Dominant language
JavaScript
Stars
30
Forks
6
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

CSV values for select-menu-labels cannot have spaces following commas. Whitespace trimming after splitting on , should allow this.

Steps to reproduce

<!-- select-menu-labels: Operating System, Installation Method -->

produces two menus, with id's as:

<select id="operating-system">
...
<select id="-installation-method">

Expected behavior

Installation Method should not be prefixed by a hyphen -

Screenshots

Additional context

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.