jsvine / jsvine/waybackpack

Saving url query string in filename

Open
#29 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.2k
Forks
214
PR merge metrics
No merged PRs in 30d

Description

Currently if you try to save a resource with the template of:

www.site.com/news?385

It will save it as merely "news" instead of something like news@385 (like what wget does).

I looked through the code and couldn't find the part that is handling the url query, but if one is saving a large amounts of files in that format, it becomes less userfriendly to simply have a thousand files labeled "news".

Awesome program by the way.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the filename-generation logic used when downloading archived URLs, then reproduce the issue with a URL containing a query string such as www.site.com/news?385. Confirm how query strings are currently discarded and define completion as saving distinct query-bearing resources with distinguishable filenames, without breaking ordinary URLs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.