jsvine / jsvine/notebookjs

Doesn't render an image from the `attachments` section

Open
#53 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug enhancement help wanted
Dominant language
JavaScript
Stars
298
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Hello,

The library doesn't render files with an image from the attachments section correctly.
An example of the file:
example.ipynb.zip

Here is how the Visual Studio Code renders the example:
CleanShot 2024-02-22 at 18 16 26

And here is how the nbpreview renders the example:
CleanShot 2024-02-22 at 18 21 28

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by opening the attached example.ipynb.zip and comparing its attachments rendering with the Visual Studio Code result and the nbpreview result. Trace the notebook rendering entry point that handles the attachments section; done means the image in the example renders correctly rather than matching the current nbpreview output.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jupyter-notebook
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.