jsvine / jsvine/notebookjs

Since 21-Jul-2021 your package does not work in Chrome

Open
#36 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
298
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Since version 92 of Chrome, SharedArraybuffer needs a special cross-origin setting. Without it, you get the error below.
Maybe you can drop the usage of webidl-conversions. They say you should not use it, even in THEIR readme.md

bundle.js:10825 Uncaught ReferenceError: SharedArrayBuffer is not defined
at Object.../node_modules/notebookjs/node_modules/webidl-conversions/lib/index.js (bundle.js:10825)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/dist/URL.js (bundle.js:10843)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/webidl2js-wrapper.js (bundle.js:10903)
at i (bundle.js:1)
at Object.../node_modules/notebookjs/node_modules/whatwg-url/index.js (bundle.js:10897)
at i (bundle.js:1)
at Object. (bundle.js:7663)
at Object.../node_modules/notebookjs/node_modules/jsdom/lib/api.js (bundle.js:7663)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the SharedArrayBuffer error in Chrome 92 and inspect the bundle.js stack through webidl-conversions, whatwg-url, and jsdom. Determine whether the dependency path can be changed as suggested; done means the package renders without the ReferenceError in the affected browser.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.