Apply ansi_up to "text" output
@jsvine is already working on this.
Since Oct 15, 2021.
- Dominant language
- CSS
- Stars
- 310
- Forks
- 67
- PR merge metrics
- No merged PRs in 30d
Description
Almond and others output ansi-formatted text as "text/plain"
ex. https://github.com/almond-sh/almond/blob/master/examples/plotly-scala.ipynb
GitHub filters this out (without highlighting), but nbpreview is currently not even doing the filtering. This results in garbled text:
I would recommend applying at least the filtering of ansi, possibly the highlighting as well. I made the following tweak locally:
nb.display.text=function(text){var el=makeElement("pre",["text-output"]);el.innerHTML=nb.highlighter(nb.ansi(joinText(text)),el);return el}
Resulting in:
Best
Justin
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.