jsvine / jsvine/markovify

markovify's make_sentence_with_start() doesn't seem to work properly

Open
#181 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.4k
Forks
348
PR merge metrics
No merged PRs in 30d

Description

heya @jsvine. i'm writing a quite simple code with markovify, and i keep running into couple of issues.

  1. m_s_w_s doesn't see the sentences with words when they're clearly there, strict=False
  2. for some reason, when my generated prompt is exactly two word-long, it gives me a KeyErrorL: ('wors_a', 'word_b)').
    it works in some cases as it expected to work, though, but in my tests issues happen a lot more often. i can give you the code if you need it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at make_sentence_with_start(), focusing on the strict=False path and the two-word prompt case described in the issue. Reproduce both reported failures with a minimal example; done means valid matching sentences are found and the two-word prompt no longer raises the reported KeyError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.