missing utf-8 BOM lead to codec failures during tests on windows
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.4k
- Forks
- 348
- PR merge metrics
- No merged PRs in 30d
Description
FYI, as #174 stimulated my curiosity, one of the two test files lacks BOM bytes:
$ hd -n4 test/texts/sherlock.txt
00000000 ef bb bf 50 |...P|
00000004
$ hd -n4 test/texts/senate-bills.txt
00000000 32 31 73 74 |21st|
00000004
and this seems not to please windows' machines (unices will probably have a better autodetection thing). I don't see this as a problem per se, as leaving correct input mangling is probably a user's task but it lowers x-files factor on previous commits ;)
thank you, regards
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the first bytes of test/texts/senate-bills.txt with test/texts/sherlock.txt, then run the affected tests on Windows. Done means the test input is handled without the reported codec failures while remaining valid input for other platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- operating-systems, testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100