jspreadsheet / jspreadsheet/ce

Bug: Undo fails when selection includes a readonly column

Open
#626 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
7.2k
Forks
890
PR merge metrics
No merged PRs in 30d

Description

First off - jExcel is amazing, I can't imagine the amount of work that must have went into it.

I've noticed that when I try to delete a selection that includes a readonly cell then undo the delete action the cells after the readonly column don't get restored and an error Cannot read property 'col' of undefined is shown. Here is a short video that demonstrates this behaviour:

https://www.screencast.com/t/3FjJ4Zv6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the undo failure by deleting a selection that includes a readonly cell, using the linked video as the behavioral reference. Trace the undo handling for that selection; done means cells after the readonly column are restored and no “Cannot read property 'col' of undefined” error appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.