jspreadsheet / jspreadsheet/ce

ts: Misplacement of getConfig in Plugin interface

Open Beginner friendly
#1,803 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
7.2k
Forks
890
PR merge metrics
No merged PRs in 30d

Description

The getConfig method appears to be defined inside the Plugin interface in index.d.ts, but it seems it should belong to SpreadsheetInstance.

https://github.com/jspreadsheet/ce/blob/a82cb27726442dc50601183d2d943491bf531835/dist/index.d.ts#L1302

Could you please verify if this is a type definition misplacement and update index.d.ts accordingly?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect dist/index.d.ts around line 1302 and compare the getConfig declaration with the Plugin and SpreadsheetInstance interfaces. Confirm the correct owner, update the type definition accordingly, and verify that getConfig is exposed on the intended interface without changing unrelated declarations.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.