jspreadsheet / jspreadsheet/ce
Suggestion: change thead children from td to th
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 890
- PR merge metrics
- No merged PRs in 30d
Description
The advantage of th elements is that they can be used with position:sticky CSS. Which means it become very easy to always keep the headers frozen at the top with some CSS.
I've hacked the library to output th's in the thead, and have seen no adverse effects (yet). I've done this for the headers and the filters.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the JavaScript rendering paths for thead headers and filters, then inspect the generated table markup and existing frontend tests; done means both header and filter cells render as th elements without adverse effects.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100