jspreadsheet / jspreadsheet/ce
Mask seems broken on footer columns
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 890
- PR merge metrics
- No merged PRs in 30d
Description
I've noticed that masks on footer columns seems to be broken due to an issue with this line:
https://github.com/jspreadsheet/ce/blob/fbcc95aaf18e96b831e0770717b05210be4a297c/dist/index.js#L9366
I'm not sure what the reason for this might be +obj.records.length in +obj.records.length + i but it will cause an issue further down when gettings the options for that column here:
https://github.com/jspreadsheet/ce/blob/fbcc95aaf18e96b831e0770717b05210be4a297c/dist/index.js#L7109
And will only get the right column when obj.records.length is 0.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading dist/index.js at lines 9366 and 7109, then trace how footer-column masks determine the options for a column. Reproduce the issue with non-empty records and verify that each footer column receives its own mask options rather than an offset column.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100