jspreadsheet / jspreadsheet/ce
oninsertrow event documentation needs an update
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 890
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I have been using jspreadsheet with jquery. I wanted to control when a new row is inserted and was using the event callback
oninsertrow(DOMElement el, Number rowNumber, Number numOfRows, Boolean insertBefore)
I looked at the documentation in https://jspreadsheet.com/v7/docs/quick-reference
But I realized that instead of the insertBefore variable, I was receiving the cells for the row inserted. I have tried and found that the insertBefore is returned in the next parameter and it is not documented. So it would be great to update this information for future users.
oninsertrow(DOMElement el, Number rowNumber, Number numOfRows, any[] rowRecords, Boolean insertBefore)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the v7 quick-reference documentation linked in the issue and locate the oninsertrow callback entry. Update its signature to include rowRecords before insertBefore, then verify that the documented parameter order matches the behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100