jspreadsheet / jspreadsheet/ce

Incorrect rendering of Spreadsheet created using HTML table having Nested tables.

Open
#1,238 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
7.2k
Forks
890
PR merge metrics
No merged PRs in 30d

Description

Please refer to this pen.

I am trying to create a Jexcel Spreadsheet using HTML tables, Each cell is of type HTML type. If a cell has a table in it, all <tr> elements of this table are rendered as Spreadsheet rows.

After debugging the issue. I found that the following line of code is causing the problem.
var content = el.querySelectorAll('table > tr, tbody tr');.

This line of code selects all <tr> elements under the tbody tag, irrespective of the nested HTML table.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodePen reproduction and search the codebase for el.querySelectorAll('table > tr, tbody tr'). Confirm how the selector includes rows from nested HTML tables, then verify that top-level table rows still render while nested-table rows remain inside their cell.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.