jspreadsheet / jspreadsheet/ce
appearance problem
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 7.2k
- Forks
- 890
- PR merge metrics
- No merged PRs in 30d
Description
-
When delete rows or columns, it uses window.confirm to choose yes or no. Is it possible that use an async confirm method? So that I can replace it with a beautiful component. The confirm dialog looks like below:
-
When I scroll to the last column, and then double click 'image' type column, the dialog is not at the right position and close button has something wrong. The dialog looks like below:
By the way, I use jexcel in Vue 2.x.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the two cases in a Vue 2.x integration: deleting rows or columns, and double-clicking an image column after scrolling to the last column. Trace the confirmation and image-editor dialog entry points used by the grid. Done means the confirmation can be replaced asynchronously and the image dialog is correctly positioned with a working close button.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100