json-schema-org / json-schema-org/website

✨ Enhancement: DocsHelp component option to hide Edit This on GitHub

Open
#1,099 19 comments 0 reactions 1 assignee View on GitHub

@arpitkuriyal is already working on this.

Since Nov 11, 2024.

✨ Enhancement good first issue Status: Accepted Status: In Progress Status: Stale
Dominant language
HTML
Stars
169
Forks
484
Avg merge
2d 2h
Merged PRs (30d)
6

Description

Is your feature request related to a problem? Please describe

The pages using DocsHelp component, have a link "Edit this page on GitHub". In case of /tools it goes to https://github.com/json-schema-org/website/blob/main/pages/%2Ftools/index.page.tsx, which seems to just be the layout of the page, not the content itself. As discussed most of the time people would want to add or edit entries for their own tool.

Describe the solution you'd like

We can add an option to feedback component (DocsHelp) to disable/hide the Edit this page on GitHub or an option to pass a custom link, in this case the tooling data.

Describe alternatives you've considered

No response

Additional context

No response

Are you working on this?

No

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.