json-schema-org / json-schema-org/JSON-Schema-Test-Suite

Test suite CI should ensure tests' schema IDs are unique

Open
#423 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
750
Forks
307
Avg merge
3d 17h
Merged PRs (30d)
24

Description

Per discussion at https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/360 and https://github.com/json-schema-org/JSON-Schema-Test-Suite/pull/509#discussion_r700744243

The test suite sanity checker should collects all the $ids used in tests and verify they're unique, to make it easier on implementers whose implementations cache references or who wish to load all references at once.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the test suite sanity checker and the CI path that runs it, then trace how schemas and their $ids are collected from the tests. Confirm the checker reports duplicate IDs, and verify the CI check passes for the existing suite while failing when an ID is repeated.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.