json-schema-org / json-schema-org/JSON-Schema-Test-Suite
tests regarding RFC 3987 incomplete
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 750
- Forks
- 307
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 24
Description
existing tests regarding RFC 3987 seam incomplete.
they lack or are incomplete to some aspects:
- ipv4address / ipv4address / ipvfuture
- iauthority / iuserinfo
- fragment
- ucschar / iunreserved / unreserved
I'd propose improving the existing test suites by adding more test cases.
there is a more sophisticated test suite, that I propose to incorporate:
- https://github.com/jkowalleck/rfc3987-syntax2/blob/main/tests/_data/invalid_syntax.json
- https://github.com/jkowalleck/rfc3987-syntax2/blob/main/tests/_data/valid_syntax.json
existing test suites:
tests/v1/format/iri-reference.json- https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/main/tests/v1/format/iri-reference.jsontests/draft7/optional/format/iri-reference.json- https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/main/tests/draft7/optional/format/iri-reference.jsontests/draft2019-09/optional/format/iri-reference.json- https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/main//tests/draft2019-09/optional/format/iri-reference.jsontests/draft2020-12/optional/format/iri-reference.json- https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/main/tests/draft2020-12/optional/format/iri-reference.jsontests/draft7/format.json- https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/main//tests/draft7/format.json
did i miss something?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the existing tests in tests/v1/format/iri-reference.json and the listed draft and format.json suites with the valid_syntax.json and invalid_syntax.json datasets. Focus on the named RFC 3987 components, including ipv4address, ipvfuture, iauthority, iuserinfo, fragment, ucschar, iunreserved, and unreserved. Done means the relevant existing suites include the missing cases and consistently represent the expected valid or invalid syntax.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100