jshawl / jshawl/future

Code will not work correctly if user uses Google from another country

Open
#3 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

In app.js if(window.location.href.match(/www.google.com\/search/)){ assumes that the user uses google.com so it will not work with google.co.uk or google.fr for instance.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read app.js and inspect the URL check around the Google search match. Verify how the current pattern behaves for google.com, google.co.uk, and google.fr, then update the handling so those country domains work as described; confirm each example is recognized.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.