jsbench / jsbench/jsbench.github.io
The bouncing down-arrow doesn't disappear during re-runs, skewing results
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 263
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
After jsbench runs a test, a bouncing down-arrow appears (it's <div ref="scrollTo" class="app__scrollto" style=""></div>). When clicked, the arrow scrolls you to the charts at the bottom.
However, if you re-run the test by clicking the "Run" button, without ever having clicked the down arrow, it reruns the test while the bouncing animation is still going. This can significantly skew test results in some cases, depending on what is being tested.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the benchmark playground: run a test, do not click the bouncing down-arrow, and run the test again. Trace the Run action and the scrollTo element, then verify that the arrow's animation is stopped or removed before the second benchmark begins.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100