jsantell / jsantell/web-audio-api-bugs
Re-using <audio /> tags
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 8
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
Not sure if you already stumbled acros it, but I had trouble re-using a tag for more files. Turned out it was still being referenced on. See this ChangeLog entry from Chrome:
webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaElementSource):
webaudio/AudioContext.h:
webaudio/AudioContext.idl:
AudioContext::createMediaElementSource() is now more careful to check that an HTMLMediaElement
doesn't already have a MediaElementAudioSourceNode attached to it.
So removing and re-adding it from the DOM does the trick.
Perhaps this can save some people the searching I did :)
Cheers,
Richard
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The report names webaudio/AudioContext.cpp, webaudio/AudioContext.h, and webaudio/AudioContext.idl, and cites AudioContext::createMediaElementSource(). Start by reproducing the audio-element reuse behavior described in the issue and comparing it with the referenced Chrome ChangeLog entry. The report does not specify a concrete implementation or documentation change as the definition of done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100