jsantell / jsantell/node-zip-dir
fails if folder does not exist
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 47
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
I tried to save to a folder that does not exist and the zip function fails. here is the full command:
var zipdir = require('zip-dir');
var sourceDir = './dist';
var version = '1.0.99';
zipdir(sourceDir, {
each: path => console.log(path, "added!"),
saveTo: `./package/CatTools.${version}.zip`
}, (err, buffer) => {
if (err) {
console.log(err);
process.exit(1);
} else {
//do some other stuff
}
});
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the shown zip-dir call and a saveTo path whose parent folder does not exist. Inspect the saveTo handling and determine the expected behavior for a missing destination folder; done when the behavior is covered by a test and the command no longer fails unexpectedly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100