jsantell / jsantell/node-cfx

Make Python execution less platform-dependent

Open
#11 7 comments 0 reactions 1 assignee View on GitHub

@peacememories is already working on this.

Since Mar 25, 2015.

enhancement
Dominant language
JavaScript
Stars
4
Forks
1
PR merge metrics
No merged PRs in 30d

Description

This issue is a continuation #7
Using python2 as an executable name solves some of the problems on Linux.
On systems without this naming scheme though, everything breaks down, so to say.
I propose using something like python-shell or node-python.
The binary location could then be exposed via a library options, with fallbacks on an environment variable and a hardcoded value (or a search for the executable if we think that's a good idea^^).

The other benefit of switching to a separate library for calling the python script is better output and error handling.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.