jsantell / jsantell/ImpactStorage

Need callback when load succeeds

Open
#1 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
36
Forks
8
PR merge metrics
No merged PRs in 30d

Description

I tried to modify the plugin to return the loaded JSON in a callback but wasn't successful. I know Lawnchair has a callback on successful load. Can this be done with ImpactStorage?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the ImpactStorage plugin's load path and compare it with Lawnchair's successful-load callback behavior. Confirm how loaded JSON is currently returned and identify the smallest API change needed; done means a successful load invokes a callback with the loaded JSON while preserving existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.