js-dxtools / js-dxtools/webpack-validator

outputPath validation fails on Windows

Open
#139 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
JavaScript
Stars
290
Forks
23
PR merge metrics
No merged PRs in 30d

Description

webpack@2.1.0-beta.22
webpack-validator@2.2.9

The path check should be using the platform specific delimiter, e.g. require('path').sep

{
"metadata": {
"port": 9000,
"host": "localhost",
"ENV": "development",
"HMR": false
},
"entry": {
"app": [],
"aurelia-bootstrap": [
"aurelia-bootstrapper-webpack",
"aurelia-polyfills",
"aurelia-pal",
"aurelia-pal-browser",
"regenerator-runtime",
"bluebird"
],
"aurelia": [
"aurelia-binding",
"aurelia-dependency-injection",
"aurelia-event-aggregator",
"aurelia-framework",
"aurelia-history",
"aurelia-history-browser",
"aurelia-loader",
"aurelia-loader-webpack",
"aurelia-logging",
"aurelia-logging-console",
"aurelia-metadata",
"aurelia-path",
"aurelia-route-recognizer",
"aurelia-router",
"aurelia-task-queue",
"aurelia-templating",
"aurelia-templating-binding",
"aurelia-templating-router",
"aurelia-templating-resources"
]
},
"output": {
"path": "C:\Git\proximus\dist",
"filename": "[name].bundle.js",
"sourceMapFilename": "[name].bundle.map",
"chunkFilename": "[id].chunk.js"
},
"externals": {
"jquery": "jQuery"
},
"devServer": {
"stats": {
"colors": true,
"hash": false,
"version": true,
"timings": false,
"assets": true,
"chunks": false,
"modules": false,
"reasons": false,
"children": false,
"source": false,
"errors": true,
"errorDetails": true,
"warnings": true,
"publicPath": false
},
"port": 9000,
"host": "localhost",
"historyApiFallback": true,
"watchOptions": {
"aggregateTimeout": 300,
"poll": 1000
},
"outputPath" [1]: "C:\Git\proximus\dist"
},
"debug": true,
"devtool": "cheap-module-inline-source-map",
"plugins": [
{
"definitions": {
"DEV": true,
"ENV": ""development"",
"HMR": false,
"process.env": {
"ENV": ""development"",
"NODE_ENV": ""development"",
"HMR": false,
"WEBPACK_HOST": ""localhost"",
"WEBPACK_PORT": "9000"
}
}
}
]
}

[1] "outputPath" should end with a slash (example: "/assets/" or "http://cdn.example.com/assets/[hash]/")

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the outputPath validation entry point in webpack-validator and inspect how the path delimiter is checked. Verify the behavior with the reported Windows path and ensure valid slash-terminated paths such as /assets/ and URL paths remain accepted. Done means Windows outputPath values no longer produce the shown validation error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, webpack
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.