jquery / jquery/sizzle

Limit all test suite selection operations to #qunit-fixture

Open
#375 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
JavaScript
Stars
6.3k
Forks
927
PR merge metrics
No merged PRs in 30d

Description

Cf. jquery/jquery/issues/2880

This issue should close when one of the following two conditions are satisfied:

  • Someone adds a comment certifying that they have examined all unit tests and found no selections scoped so broadly that they could match QUnit output.
  • A commit lands on the master branch claiming to correct all such selections (e.g., by either scoping more tightly or—for those that are explicitly document-scope—reducing with jQuery#filter( "#qunit-fixture *" ) before comparing to expected results).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading jquery/jquery/issues/2880, then examine all unit tests for selections broad enough to match QUnit output. Done means either a comment certifies that no such selections remain or a commit on master corrects every one by scoping it more tightly or filtering document-scope results to #qunit-fixture * before comparison.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.