jQuery.Animation shouldn't end empty animations early
Open
Nobody has claimed this yet.
Bug
Effects
- Dominant language
- JavaScript
- Stars
- 59.8k
- Forks
- 20.4k
- Avg merge
- 17h 32m
- Merged PRs (30d)
- 4
Description
Description
Although .animate({}) finishes immediately, the deeper jQuery.Animate infrastructure should not, because occasionally show/hide animations end up empty (observed in an intermediate step of #3496), but we don't want to throw off timing in those cases.
Link to test case
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior in the linked JSFiddle and reading the jQuery.Animate infrastructure involved in empty show/hide animation steps. Done means an empty internal animation preserves the expected timing while an explicit .animate({}) still finishes immediately.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100