There are some inconsistencies with the current (and old) ThemeRoller
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 11.3k
- Forks
- 5.2k
- PR merge metrics
- No merged PRs in 30d
Description
Modify url not working correctly with background textures
If you configure a theme and select a different type for the textures, e.g. "highlight_soft", the theme is created correctly.
However, if you then use the URL from one of the CSS files, all textures are set to "flat" again
"bgTexture[Type]" are loaded allways with the default value "flat"
example custom theme
Theme-Custom-Url-With-bg.txt
Quality of iconsets not identical
The iconsets (2024) are not identical to the ThemeRoller version jQuery 11.4. Some icons are much blurrier
I have attached the icon sets of both versions
jquery-ui-1.12.1-iconsets.zip
jquery-ui-1.11.4-iconsets.zip
jQuery UI 11.4
jQuery UI 12.x / 13.x
the differences can be seen very clearly in lines 1,2, 7 and 8
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the ThemeRoller custom theme and loading the URL from one of its CSS files, checking why each bgTexture[Type] returns to flat. Then compare the attached jquery-ui-1.12.1-iconsets.zip and jquery-ui-1.11.4-iconsets.zip files against the displayed icon differences. Done means URL-loaded themes retain their selected texture types and the affected iconsets have equivalent quality.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, jquery
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100