jquery / jquery/jquery-ui

Active State for menus in 1.13.0 with Smoothness Theme

Open
#2,033 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Behavior shared with 1.12 Comp: Menu
Dominant language
JavaScript
Stars
11.3k
Forks
5.2k
PR merge metrics
No merged PRs in 30d

Description

The active state for menu items in the default theme has a blue background and all the other themes I checked makes the active item stand out visuall... but the smoothness theme only adds a light gray border. It's also different from how it looked in 1.12. I'm not sure if this is a bug or intentional. Either way, I think it could be improved.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the Smoothness theme's menu active-state styles and comparing them with the default theme and the 1.12 appearance. Confirm the intended visual treatment with the project context, then verify that active menu items are visibly distinct without regressing other themes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jquery
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.